Enhancement: Extract FieldDefinition\Reference

ergebnis · Apr 2, 2020 · 047c75b · 047c75b
1 parent aea1cbb
commit 047c75b
Show file tree

Hide file tree

Showing 8 changed files with 12 additions and 8 deletions.
diff --git a/.github/workflows/integrate.yaml b/.github/workflows/integrate.yaml
@@ -9,8 +9,8 @@ on: # yamllint disable-line rule:truthy
       - "master"
 
 env:
-  MIN_COVERED_MSI: 98
-  MIN_MSI: 96
+  MIN_COVERED_MSI: 99
+  MIN_MSI: 97
   REQUIRED_PHP_EXTENSIONS: "mbstring"
 
 jobs:

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -30,6 +30,7 @@ For a full diff see [`fa9c564...master`][fa9c564...master].
 * Started throwing an `Exception\ClassNotFound` exception instead of a generic `Exception` when a class was not found ([#125]), by [@localheinz]
 * Added `@template` annotations to assist with static code analysis ([#128]), by [@localheinz]
 * Removed the fluent interface from `FixtureFactory::defineEntity()` ([#131]), by [@localheinz]
+* Extracted `FieldDefinition\Reference` ([#157]), by [@localheinz]
 
 ### Fixed
 
@@ -82,5 +83,6 @@ For a full diff see [`fa9c564...master`][fa9c564...master].
 [#133]: https://github.com/ergebnis/factory-bot/pull/133
 [#149]: https://github.com/ergebnis/factory-bot/pull/149
 [#155]: https://github.com/ergebnis/factory-bot/pull/155
+[#157]: https://github.com/ergebnis/factory-bot/pull/157
 
 [@localheinz]: https://github.com/localheinz
diff --git a/Makefile b/Makefile
@@ -1,5 +1,5 @@
-MIN_COVERED_MSI:=98
-MIN_MSI:=96
+MIN_COVERED_MSI:=99
+MIN_MSI:=97
 
 .PHONY: it
 it: coding-standards static-code-analysis tests ## Runs the coding-standards, static-code-analysis, and tests targets

diff --git a/src/FieldDefinition.php b/src/FieldDefinition.php
@@ -13,9 +13,6 @@
 
 namespace Ergebnis\FactoryBot;
 
-/**
- * Contains static methods to define fields as sequences, references etc.
- */
 final class FieldDefinition implements FieldDefinition\Resolvable
 {
     private $closure;

diff --git a/test/Integration/FixtureFactoryTest.php b/test/Integration/FixtureFactoryTest.php
@@ -25,6 +25,7 @@
  *
  * @uses \Ergebnis\FactoryBot\EntityDefinition
  * @uses \Ergebnis\FactoryBot\FieldDefinition
+ * @uses \Ergebnis\FactoryBot\FieldDefinition\Reference
  */
 final class FixtureFactoryTest extends AbstractTestCase
 {

diff --git a/test/Unit/FieldDefinition/ReferenceTest.php b/test/Unit/FieldDefinition/ReferenceTest.php
@@ -23,6 +23,8 @@
  *
  * @covers \Ergebnis\FactoryBot\FieldDefinition\Reference
  *
+ * @uses \Ergebnis\FactoryBot\EntityDefinition
+ * @uses \Ergebnis\FactoryBot\FieldDefinition
  * @uses \Ergebnis\FactoryBot\FixtureFactory
  */
 final class ReferenceTest extends AbstractTestCase

diff --git a/test/Unit/FieldDefinitionTest.php b/test/Unit/FieldDefinitionTest.php
@@ -26,6 +26,7 @@
  *
  * @uses \Ergebnis\FactoryBot\EntityDefinition
  * @uses \Ergebnis\FactoryBot\Exception\InvalidCount
+ * @uses \Ergebnis\FactoryBot\FieldDefinition\Reference
  * @uses \Ergebnis\FactoryBot\FixtureFactory
  */
 final class FieldDefinitionTest extends AbstractTestCase

diff --git a/test/Unit/FixtureFactoryTest.php b/test/Unit/FixtureFactoryTest.php
@@ -26,13 +26,14 @@
  * @covers \Ergebnis\FactoryBot\FixtureFactory
  *
  * @uses \Ergebnis\FactoryBot\EntityDefinition
- * @uses \Ergebnis\FactoryBot\FieldDefinition
  * @uses \Ergebnis\FactoryBot\Exception\ClassMetadataNotFound
  * @uses \Ergebnis\FactoryBot\Exception\ClassNotFound
  * @uses \Ergebnis\FactoryBot\Exception\EntityDefinitionAlreadyRegistered
  * @uses \Ergebnis\FactoryBot\Exception\EntityDefinitionNotRegistered
  * @uses \Ergebnis\FactoryBot\Exception\InvalidCount
  * @uses \Ergebnis\FactoryBot\Exception\InvalidFieldNames
+ * @uses \Ergebnis\FactoryBot\FieldDefinition
+ * @uses \Ergebnis\FactoryBot\FieldDefinition\Reference
  */
 final class FixtureFactoryTest extends AbstractTestCase
 {