Skip to content

Commit

Permalink
Merge pull request #372 from ergebnis/fix/required
Browse files Browse the repository at this point in the history 
Fix: Method names
  • Loading branch information
@ergebnis-bot
ergebnis-bot committed Aug 5, 2020
2 parents 3c640e2 + c1182d8 commit 817ec70
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 17 deletions.
10 changes: 5 additions & 5 deletions test/Unit/FieldDefinitionTest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
*/
final class FieldDefinitionTest extends AbstractTestCase
{
public function testClosureReturnsRequiredClosure(): void
public function testClosureReturnsClosure(): void
{
$closure = static function (Generator $faker, FixtureFactory $fixtureFactory): Entity\User {
/** @var Entity\User $user */
Expand Down Expand Up @@ -73,7 +73,7 @@ public function testOptionalClosureReturnsOptionalClosure(): void
self::assertEquals($expected, $fieldDefinition);
}

public function testReferenceReturnsRequiredReference(): void
public function testReferenceReturnsReference(): void
{
$className = Entity\User::class;

Expand Down Expand Up @@ -136,7 +136,7 @@ public function testSequenceRejectsValueWhenItIsMissingPercentDPlaceholder(): vo
);
}

public function testSequenceReturnsRequiredSequenceWhenValueContainsPlaceholderAndInitialNumberIsNotSpecified(): void
public function testSequenceReturnsSequenceWhenValueContainsPlaceholderAndInitialNumberIsNotSpecified(): void
{
$value = 'there-is-no-difference-between-%d-and-%d';

Expand All @@ -155,7 +155,7 @@ public function testSequenceReturnsRequiredSequenceWhenValueContainsPlaceholderA
*
* @param int $initialNumber
*/
public function testSequenceReturnsRequiredSequenceWhenValueContainsPlaceholderAndInitialNumberIsSpecified(int $initialNumber): void
public function testSequenceReturnsSequenceWhenValueContainsPlaceholderAndInitialNumberIsSpecified(int $initialNumber): void
{
$value = 'there-is-no-difference-between-%d-and-%d';

Expand Down Expand Up @@ -232,7 +232,7 @@ public function testOptionalSequenceReturnsOptionalSequenceWhenValueContainsPlac
*
* @param mixed $value
*/
public function testValueReturnsRequiredValue($value): void
public function testValueReturnsValue($value): void
{
$fieldDefinition = FieldDefinition::value($value);

Expand Down
12 changes: 6 additions & 6 deletions test/Unit/FixtureFactory/UsingDefaultStrategyTest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ public function testCreateOneResolvesOptionalClosureToResultOfClosureInvokedWith
self::assertInstanceOf(Entity\CodeOfConduct::class, $repository->codeOfConduct());
}

public function testCreateOneResolvesRequiredClosureToResultOfClosureInvokedWithFakerAndFixtureFactoryWhenFakerReturnsFalse(): void
public function testCreateOneResolvesClosureToResultOfClosureInvokedWithFakerAndFixtureFactoryWhenFakerReturnsFalse(): void
{
$fixtureFactory = new FixtureFactory(
self::entityManager(),
Expand All @@ -102,7 +102,7 @@ public function testCreateOneResolvesRequiredClosureToResultOfClosureInvokedWith
self::assertInstanceOf(Entity\CodeOfConduct::class, $repository->codeOfConduct());
}

public function testCreateOneResolvesRequiredClosureToResultOfClosureInvokedWithFakerAndFixtureFactoryWhenFakerReturnsTrue(): void
public function testCreateOneResolvesClosureToResultOfClosureInvokedWithFakerAndFixtureFactoryWhenFakerReturnsTrue(): void
{
$fixtureFactory = new FixtureFactory(
self::entityManager(),
Expand Down Expand Up @@ -161,7 +161,7 @@ public function testCreateOneResolvesOptionalReferenceToEntityWhenFakerReturnsTr
self::assertInstanceOf(Entity\CodeOfConduct::class, $repository->codeOfConduct());
}

public function testCreateOneResolvesRequiredReferenceToEntityWhenFakerReturnsFalse(): void
public function testCreateOneResolvesReferenceToEntityWhenFakerReturnsFalse(): void
{
$fixtureFactory = new FixtureFactory(
self::entityManager(),
Expand All @@ -180,7 +180,7 @@ public function testCreateOneResolvesRequiredReferenceToEntityWhenFakerReturnsFa
self::assertInstanceOf(Entity\CodeOfConduct::class, $repository->codeOfConduct());
}

public function testCreateOneResolvesRequiredReferenceToEntityWhenFakerReturnsTrue(): void
public function testCreateOneResolvesReferenceToEntityWhenFakerReturnsTrue(): void
{
$fixtureFactory = new FixtureFactory(
self::entityManager(),
Expand Down Expand Up @@ -371,7 +371,7 @@ public function testCreateOneResolvesOptionalSequenceToStringValueWhenPercentDPl
self::assertSame('City (3)', $userThree->location());
}

public function testCreateOneResolvesRequiredSequenceToStringValueWhenPercentDPlaceholderIsPresentAndFakerReturnsFalse(): void
public function testCreateOneResolvesSequenceToStringValueWhenPercentDPlaceholderIsPresentAndFakerReturnsFalse(): void
{
$fixtureFactory = new FixtureFactory(
self::entityManager(),
Expand All @@ -396,7 +396,7 @@ public function testCreateOneResolvesRequiredSequenceToStringValueWhenPercentDPl
self::assertSame('City (3)', $userThree->location());
}

public function testCreateOneResolvesRequiredSequenceToStringValueWhenPercentDPlaceholderIsPresentAndFakerReturnsTrue(): void
public function testCreateOneResolvesSequenceToStringValueWhenPercentDPlaceholderIsPresentAndFakerReturnsTrue(): void
{
$fixtureFactory = new FixtureFactory(
self::entityManager(),
Expand Down
12 changes: 6 additions & 6 deletions test/Unit/FixtureFactory/UsingWithOptionalStrategyTest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ public function testCreateOneResolvesOptionalClosureToResultOfClosureInvokedWith
self::assertInstanceOf(Entity\CodeOfConduct::class, $repository->codeOfConduct());
}

public function testCreateOneResolvesRequiredClosureToResultOfClosureInvokedWithFakerAndFixtureFactoryWhenFakerReturnsFalse(): void
public function testCreateOneResolvesClosureToResultOfClosureInvokedWithFakerAndFixtureFactoryWhenFakerReturnsFalse(): void
{
$fixtureFactory = new FixtureFactory(
self::entityManager(),
Expand All @@ -109,7 +109,7 @@ public function testCreateOneResolvesRequiredClosureToResultOfClosureInvokedWith
self::assertInstanceOf(Entity\CodeOfConduct::class, $repository->codeOfConduct());
}

public function testCreateOneResolvesRequiredClosureToResultOfClosureInvokedWithFakerAndFixtureFactoryWhenFakerReturnsTrue(): void
public function testCreateOneResolvesClosureToResultOfClosureInvokedWithFakerAndFixtureFactoryWhenFakerReturnsTrue(): void
{
$fixtureFactory = new FixtureFactory(
self::entityManager(),
Expand Down Expand Up @@ -174,7 +174,7 @@ public function testCreateOneResolvesOptionalReferenceToEntityWhenFakerReturnsTr
self::assertInstanceOf(Entity\CodeOfConduct::class, $repository->codeOfConduct());
}

public function testCreateOneResolvesRequiredReferenceToEntityWhenFakerReturnsFalse(): void
public function testCreateOneResolvesReferenceToEntityWhenFakerReturnsFalse(): void
{
$fixtureFactory = new FixtureFactory(
self::entityManager(),
Expand All @@ -195,7 +195,7 @@ public function testCreateOneResolvesRequiredReferenceToEntityWhenFakerReturnsFa
self::assertInstanceOf(Entity\CodeOfConduct::class, $repository->codeOfConduct());
}

public function testCreateOneResolvesRequiredReferenceToEntityWhenFakerReturnsTrue(): void
public function testCreateOneResolvesReferenceToEntityWhenFakerReturnsTrue(): void
{
$fixtureFactory = new FixtureFactory(
self::entityManager(),
Expand Down Expand Up @@ -408,7 +408,7 @@ public function testCreateOneResolvesOptionalSequenceToStringValueWhenPercentDPl
self::assertSame('City (3)', $userThree->location());
}

public function testCreateOneResolvesRequiredSequenceToStringValueWhenPercentDPlaceholderIsPresentAndFakerReturnsFalse(): void
public function testCreateOneResolvesSequenceToStringValueWhenPercentDPlaceholderIsPresentAndFakerReturnsFalse(): void
{
$fixtureFactory = new FixtureFactory(
self::entityManager(),
Expand All @@ -435,7 +435,7 @@ public function testCreateOneResolvesRequiredSequenceToStringValueWhenPercentDPl
self::assertSame('City (3)', $userThree->location());
}

public function testCreateOneResolvesRequiredSequenceToStringValueWhenPercentDPlaceholderIsPresentAndFakerReturnsTrue(): void
public function testCreateOneResolvesSequenceToStringValueWhenPercentDPlaceholderIsPresentAndFakerReturnsTrue(): void
{
$fixtureFactory = new FixtureFactory(
self::entityManager(),
Expand Down

0 comments on commit 817ec70

Please sign in to comment.