Skip to content

Commit

Permalink
Merge pull request #361 from ergebnis/fix/signature
Browse files Browse the repository at this point in the history
Fix: Signature of closure
  • Loading branch information
ergebnis-bot committed Aug 4, 2020
2 parents e341174 + 1667c7c commit afd0815
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions test/Unit/FieldDefinitionTest.php
Expand Up @@ -18,6 +18,7 @@
use Ergebnis\FactoryBot\FieldDefinition;
use Ergebnis\FactoryBot\FixtureFactory;
use Example\Entity;
use Faker\Generator;

/**
* @internal
Expand All @@ -38,7 +39,7 @@ final class FieldDefinitionTest extends AbstractTestCase
{
public function testClosureReturnsRequiredClosure(): void
{
$closure = static function (FixtureFactory $fixtureFactory): Entity\User {
$closure = static function (Generator $faker, FixtureFactory $fixtureFactory): Entity\User {
/** @var Entity\User $user */
$user = $fixtureFactory->createOne(Entity\User::class);

Expand All @@ -56,7 +57,7 @@ public function testClosureReturnsRequiredClosure(): void

public function testOptionalClosureReturnsOptionalClosure(): void
{
$closure = static function (FixtureFactory $fixtureFactory): Entity\User {
$closure = static function (Generator $faker, FixtureFactory $fixtureFactory): Entity\User {
/** @var Entity\User $user */
$user = $fixtureFactory->createOne(Entity\User::class);

Expand Down
2 changes: 1 addition & 1 deletion test/Unit/FixtureFactoryTest.php
Expand Up @@ -503,7 +503,7 @@ public function testCreateOneResolvesOptionalClosureToNullWhenFakerReturnsFalse(
$fixtureFactory->define(Entity\CodeOfConduct::class);

$fixtureFactory->define(Entity\Repository::class, [
'codeOfConduct' => FieldDefinition::optionalClosure(static function (FixtureFactory $fixtureFactory): Entity\CodeOfConduct {
'codeOfConduct' => FieldDefinition::optionalClosure(static function (Generator $faker, FixtureFactory $fixtureFactory): Entity\CodeOfConduct {
return $fixtureFactory->createOne(Entity\CodeOfConduct::class);
}),
]);
Expand Down

0 comments on commit afd0815

Please sign in to comment.