Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Slide method #100

Merged
merged 1 commit into from
Mar 28, 2020
Merged

Fix: Slide method #100

merged 1 commit into from
Mar 28, 2020

Conversation

localheinz
Copy link
Member

This PR

  • slides a method

Follows #1.

💁‍♂ This brings

  • constructor parameters
  • fields
  • accessors

in consistent order.

@localheinz localheinz added the bug label Mar 28, 2020
@localheinz localheinz self-assigned this Mar 28, 2020
@codecov
Copy link

codecov bot commented Mar 28, 2020

Codecov Report

Merging #100 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #100   +/-   ##
=========================================
  Coverage     93.71%   93.71%           
  Complexity       75       75           
=========================================
  Files             9        9           
  Lines           207      207           
=========================================
  Hits            194      194           
  Misses           13       13           
Impacted Files Coverage Δ Complexity Δ
src/EntityDefinition.php 100.00% <100.00%> (ø) 4.00 <2.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1105e4...1e7d6bf. Read the comment docs.

@localheinz localheinz merged commit 9346895 into master Mar 28, 2020
@localheinz localheinz deleted the fix/slide branch March 28, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant