Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove AbstractDefinition #116

Merged
merged 1 commit into from
Mar 29, 2020
Merged

Conversation

localheinz
Copy link
Member

This PR

  • actually removes AbstractDefinition

Follows #114.

🍷

@localheinz localheinz added the bug label Mar 29, 2020
@localheinz localheinz self-assigned this Mar 29, 2020
@codecov
Copy link

codecov bot commented Mar 29, 2020

Codecov Report

Merging #116 into master will increase coverage by 3.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #116      +/-   ##
============================================
+ Coverage     91.36%   94.36%   +3.00%     
+ Complexity       80       77       -3     
============================================
  Files            11       10       -1     
  Lines           220      213       -7     
============================================
  Hits            201      201              
+ Misses           19       12       -7     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e868897...ecc8fc1. Read the comment docs.

@localheinz localheinz merged commit 04ad03d into master Mar 29, 2020
@localheinz localheinz deleted the fix/abstract-definition branch March 29, 2020 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant