Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove singleton capabilities #124

Merged
merged 1 commit into from Mar 30, 2020
Merged

Fix: Remove singleton capabilities #124

merged 1 commit into from Mar 30, 2020

Conversation

localheinz
Copy link
Member

This PR

  • removes FixtureFactory::getAsSingleton(), FixtureFactory::setSingleton(), and FixtureFactory::unsetSingleton()

Follows #1.

馃拋鈥嶁檪 I have never used it, not sure if I will miss it.

@codecov
Copy link

codecov bot commented Mar 30, 2020

Codecov Report

Merging #124 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #124      +/-   ##
============================================
+ Coverage     94.23%   94.32%   +0.09%     
+ Complexity       74       67       -7     
============================================
  Files            10       10              
  Lines           208      194      -14     
============================================
- Hits            196      183      -13     
+ Misses           12       11       -1     
Impacted Files Coverage 螖 Complexity 螖
src/FieldDefinition.php 100.00% <酶> (酶) 6.00 <0.00> (酶)
src/FixtureFactory.php 91.66% <酶> (-0.14%) 38.00 <0.00> (-7.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update b503b60...8096f34. Read the comment docs.

@ergebnis-bot ergebnis-bot self-assigned this Mar 30, 2020
@ergebnis-bot ergebnis-bot self-requested a review March 30, 2020 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants