Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Turn FieldDefinition into object #129

Merged
merged 1 commit into from
Mar 31, 2020

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Mar 30, 2020

This PR

  • turns FieldDefinition into an object that can be passed around

@codecov
Copy link

codecov bot commented Mar 31, 2020

Codecov Report

Merging #129 into master will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #129      +/-   ##
============================================
+ Coverage     97.92%   98.01%   +0.09%     
- Complexity       69       72       +3     
============================================
  Files            12       12              
  Lines           193      202       +9     
============================================
+ Hits            189      198       +9     
  Misses            4        4              
Impacted Files Coverage Δ Complexity Δ
src/EntityDefinition.php 100.00% <ø> (ø) 4.00 <0.00> (ø)
src/FieldDefinition.php 100.00% <100.00%> (ø) 8.00 <8.00> (+2.00)
src/FixtureFactory.php 98.09% <100.00%> (+0.07%) 38.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe03982...42d299b. Read the comment docs.

@localheinz localheinz marked this pull request as ready for review March 31, 2020 07:24
@localheinz localheinz merged commit 8c8995a into master Mar 31, 2020
@localheinz localheinz deleted the feature/field-definition branch March 31, 2020 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant