Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Do not return FixtureFactory from defineEntity() #131

Merged
merged 1 commit into from Mar 30, 2020

Conversation

localheinz
Copy link
Member

This PR

  • stops returning FixtureFactory from FixtureFactory::defineEntity()

Follows #1.

@codecov
Copy link

codecov bot commented Mar 30, 2020

Codecov Report

Merging #131 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #131      +/-   ##
============================================
- Coverage     95.47%   95.45%   -0.03%     
  Complexity       71       71              
============================================
  Files            12       12              
  Lines           199      198       -1     
============================================
- Hits            190      189       -1     
  Misses            9        9              
Impacted Files Coverage Δ Complexity Δ
src/FixtureFactory.php 93.39% <100.00%> (-0.07%) 39.00 <12.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c99e683...f115267. Read the comment docs.

@ergebnis-bot ergebnis-bot self-assigned this Mar 30, 2020
@ergebnis-bot ergebnis-bot self-requested a review March 30, 2020 20:48
@ergebnis-bot ergebnis-bot merged commit 5e1b319 into master Mar 30, 2020
@ergebnis-bot ergebnis-bot deleted the fix/fluent branch March 30, 2020 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants