Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Extract FieldDefinition\Value #160

Merged
merged 1 commit into from Apr 2, 2020
Merged

Conversation

localheinz
Copy link
Member

This PR

  • extracts FieldDefinition\Value

Follows #157.

@codecov
Copy link

codecov bot commented Apr 2, 2020

Codecov Report

Merging #160 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #160      +/-   ##
============================================
+ Coverage     98.20%   98.23%   +0.02%     
- Complexity       79       81       +2     
============================================
  Files            15       16       +1     
  Lines           223      226       +3     
============================================
+ Hits            219      222       +3     
  Misses            4        4              
Impacted Files Coverage Δ Complexity Δ
src/FieldDefinition.php 100.00% <100.00%> (ø) 9.00 <1.00> (ø)
src/FieldDefinition/Value.php 100.00% <100.00%> (ø) 2.00 <2.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 743f4b4...8772f6e. Read the comment docs.

@ergebnis-bot ergebnis-bot self-requested a review April 2, 2020 17:54
@ergebnis-bot ergebnis-bot self-assigned this Apr 2, 2020
@localheinz localheinz merged commit eeb9193 into master Apr 2, 2020
@localheinz localheinz deleted the feature/value branch April 2, 2020 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants