Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Introduce named constructor and mark primary constructor private #188

Merged
merged 1 commit into from Apr 24, 2020

Conversation

localheinz
Copy link
Member

This PR

  • introduced named constructors for field definitions and marks primary constructor as private

Related to #167.

@codecov
Copy link

codecov bot commented Apr 24, 2020

Codecov Report

Merging #188 into master will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #188      +/-   ##
============================================
+ Coverage     97.42%   97.55%   +0.12%     
- Complexity       86       91       +5     
============================================
  Files            19       19              
  Lines           233      245      +12     
============================================
+ Hits            227      239      +12     
  Misses            6        6              
Impacted Files Coverage Δ Complexity Δ
src/FieldDefinition.php 100.00% <100.00%> (ø) 6.00 <0.00> (ø)
src/FieldDefinition/Closure.php 100.00% <100.00%> (ø) 3.00 <2.00> (+1.00)
src/FieldDefinition/Reference.php 100.00% <100.00%> (ø) 3.00 <2.00> (+1.00)
src/FieldDefinition/References.php 100.00% <100.00%> (ø) 4.00 <3.00> (+1.00)
src/FieldDefinition/Sequence.php 100.00% <100.00%> (ø) 4.00 <3.00> (+1.00)
src/FieldDefinition/Value.php 100.00% <100.00%> (ø) 3.00 <2.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f9eee1...93196f2. Read the comment docs.

@ergebnis-bot ergebnis-bot self-requested a review April 24, 2020 06:28
@ergebnis-bot ergebnis-bot self-assigned this Apr 24, 2020
@ergebnis-bot ergebnis-bot merged commit 477162a into master Apr 24, 2020
@ergebnis-bot ergebnis-bot deleted the feature/named branch April 24, 2020 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants