Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use interface in type and return type declarations #24

Merged
merged 1 commit into from
Mar 10, 2020

Conversation

localheinz
Copy link
Member

This PR

  • uses Doctrine\ORM\EntityManagerInterface instead of Doctrine\ORM\EntityManager in type and return type declarations

@localheinz localheinz added the bug label Mar 10, 2020
@localheinz localheinz self-assigned this Mar 10, 2020
@codecov
Copy link

codecov bot commented Mar 10, 2020

Codecov Report

Merging #24 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #24   +/-   ##
=========================================
  Coverage     61.85%   61.85%           
  Complexity       80       80           
=========================================
  Files             8        8           
  Lines           194      194           
=========================================
  Hits            120      120           
  Misses           74       74
Impacted Files Coverage Δ Complexity Δ
src/EntityDef.php 0% <0%> (ø) 18 <1> (ø) ⬇️
src/FixtureFactory.php 93.82% <100%> (ø) 36 <1> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 737027a...aeb9f4f. Read the comment docs.

@localheinz localheinz merged commit 1b5ca29 into master Mar 10, 2020
@localheinz localheinz deleted the fix/interface branch March 10, 2020 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant