Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Extract Count #262

Merged
merged 1 commit into from Jul 7, 2020
Merged

Enhancement: Extract Count #262

merged 1 commit into from Jul 7, 2020

Conversation

localheinz
Copy link
Member

This PR

  • extracts Count as a value object

@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #262 into main will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #262      +/-   ##
============================================
+ Coverage     97.57%   97.60%   +0.02%     
- Complexity       93       98       +5     
============================================
  Files            20       21       +1     
  Lines           247      250       +3     
============================================
+ Hits            241      244       +3     
  Misses            6        6              
Impacted Files Coverage Δ Complexity Δ
src/Count.php 100.00% <100.00%> (ø) 3.00 <3.00> (?)
src/FieldDefinition.php 100.00% <100.00%> (ø) 11.00 <3.00> (+2.00)
src/FieldDefinition/References.php 100.00% <100.00%> (ø) 2.00 <1.00> (-1.00)
src/FixtureFactory.php 96.36% <100.00%> (-0.10%) 42.00 <4.00> (+1.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7502b58...0f0be76. Read the comment docs.

@ergebnis-bot ergebnis-bot merged commit df23d4f into main Jul 7, 2020
@ergebnis-bot ergebnis-bot deleted the feature/count branch July 7, 2020 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants