Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Rename data provider #276

Merged
merged 1 commit into from
Jul 8, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,14 @@

use Ergebnis\Test\Util\Helper;

final class NumberProvider
final class IntProvider
{
use Helper;

/**
* @return \Generator<string, array<int>>
*/
public function intArbitrary(): \Generator
public function arbitrary(): \Generator
{
$values = [
'int-less-than-minus-one' => -1 * self::faker()->numberBetween(2),
Expand All @@ -42,7 +42,7 @@ public function intArbitrary(): \Generator
/**
* @return \Generator<string, array<int>>
*/
public function intLessThanOne(): \Generator
public function lessThanOne(): \Generator
{
$values = [
'int-zero' => 0,
Expand All @@ -60,7 +60,7 @@ public function intLessThanOne(): \Generator
/**
* @return \Generator<string, array<int>>
*/
public function intGreaterThanOrEqualToOne(): \Generator
public function greaterThanOrEqualToOne(): \Generator
{
$values = [
'int-one' => 1,
Expand Down
4 changes: 2 additions & 2 deletions test/Unit/CountTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
final class CountTest extends Framework\TestCase
{
/**
* @dataProvider \Ergebnis\FactoryBot\Test\DataProvider\NumberProvider::intLessThanOne()
* @dataProvider \Ergebnis\FactoryBot\Test\DataProvider\IntProvider::lessThanOne()
*
* @param int $value
*/
Expand All @@ -44,7 +44,7 @@ public function testConstructorRejectsInvalidValue(int $value): void
}

/**
* @dataProvider \Ergebnis\FactoryBot\Test\DataProvider\NumberProvider::intGreaterThanOrEqualToOne()
* @dataProvider \Ergebnis\FactoryBot\Test\DataProvider\IntProvider::greaterThanOrEqualToOne()
*
* @param int $value
*/
Expand Down
2 changes: 1 addition & 1 deletion test/Unit/FieldDefinition/ReferencesTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
final class ReferencesTest extends AbstractTestCase
{
/**
* @dataProvider \Ergebnis\FactoryBot\Test\DataProvider\NumberProvider::intGreaterThanOrEqualToOne()
* @dataProvider \Ergebnis\FactoryBot\Test\DataProvider\IntProvider::greaterThanOrEqualToOne()
*
* @param int $value
*/
Expand Down
6 changes: 3 additions & 3 deletions test/Unit/FieldDefinitionTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ public function testReferencesReturnsRequiredReferencesWhenCountIsNotSpecified()
}

/**
* @dataProvider \Ergebnis\FactoryBot\Test\DataProvider\NumberProvider::intGreaterThanOrEqualToOne()
* @dataProvider \Ergebnis\FactoryBot\Test\DataProvider\IntProvider::greaterThanOrEqualToOne()
*
* @param int $value
*/
Expand Down Expand Up @@ -166,7 +166,7 @@ public function testSequenceReturnsRequiredSequenceWhenValueContainsPlaceholderA
}

/**
* @dataProvider \Ergebnis\FactoryBot\Test\DataProvider\NumberProvider::intGreaterThanOrEqualToOne()
* @dataProvider \Ergebnis\FactoryBot\Test\DataProvider\IntProvider::greaterThanOrEqualToOne()
*
* @param int $initialNumber
*/
Expand Down Expand Up @@ -221,7 +221,7 @@ public function testOptionalSequenceReturnsOptionalSequenceWhenValueContainsPlac
}

/**
* @dataProvider \Ergebnis\FactoryBot\Test\DataProvider\NumberProvider::intArbitrary()
* @dataProvider \Ergebnis\FactoryBot\Test\DataProvider\IntProvider::arbitrary()
*
* @param int $initialNumber
*/
Expand Down
10 changes: 5 additions & 5 deletions test/Unit/FixtureFactoryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -547,7 +547,7 @@ public function testCreateOneResolvesRequiredReferenceToEntityWhenFakerReturnsTr
}

/**
* @dataProvider \Ergebnis\FactoryBot\Test\DataProvider\NumberProvider::intGreaterThanOrEqualToOne()
* @dataProvider \Ergebnis\FactoryBot\Test\DataProvider\IntProvider::greaterThanOrEqualToOne()
*
* @param int $value
*/
Expand Down Expand Up @@ -579,7 +579,7 @@ public function testCreateOneResolvesRequiredReferencesToArrayCollectionOfEntiti
}

/**
* @dataProvider \Ergebnis\FactoryBot\Test\DataProvider\NumberProvider::intGreaterThanOrEqualToOne()
* @dataProvider \Ergebnis\FactoryBot\Test\DataProvider\IntProvider::greaterThanOrEqualToOne()
*
* @param int $value
*/
Expand Down Expand Up @@ -789,7 +789,7 @@ public function testCreateOneAllowsOverridingAssociationWithNullWhenFieldDefinit
}

/**
* @dataProvider \Ergebnis\FactoryBot\Test\DataProvider\NumberProvider::intGreaterThanOrEqualToOne()
* @dataProvider \Ergebnis\FactoryBot\Test\DataProvider\IntProvider::greaterThanOrEqualToOne()
*
* @param int $value
*/
Expand Down Expand Up @@ -827,7 +827,7 @@ public function testCreateOneAllowsOverridingAssociationWithCollectionOfEntities
}

/**
* @dataProvider \Ergebnis\FactoryBot\Test\DataProvider\NumberProvider::intGreaterThanOrEqualToOne()
* @dataProvider \Ergebnis\FactoryBot\Test\DataProvider\IntProvider::greaterThanOrEqualToOne()
*
* @param int $value
*/
Expand Down Expand Up @@ -977,7 +977,7 @@ public function testCreateManyResolvesToArrayOfEntitiesWhenCountIsNotSpecified()
}

/**
* @dataProvider \Ergebnis\FactoryBot\Test\DataProvider\NumberProvider::intGreaterThanOrEqualToOne()
* @dataProvider \Ergebnis\FactoryBot\Test\DataProvider\IntProvider::greaterThanOrEqualToOne()
*
* @param int $value
*/
Expand Down