Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Verify that class implements interface #299

Merged
merged 1 commit into from
Jul 12, 2020
Merged

Conversation

localheinz
Copy link
Member

This PR

  • verifies that a candidate class implements Definition, instead of that it is a subclass of Definition

@localheinz localheinz self-assigned this Jul 12, 2020
@codecov
Copy link

codecov bot commented Jul 12, 2020

Codecov Report

Merging #299 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #299   +/-   ##
=========================================
  Coverage     98.54%   98.54%           
  Complexity      100      100           
=========================================
  Files            23       23           
  Lines           274      274           
=========================================
  Hits            270      270           
  Misses            4        4           
Impacted Files Coverage Δ Complexity Δ
src/Definitions.php 91.66% <100.00%> (ø) 10.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b479f30...5512ec3. Read the comment docs.

@ergebnis-bot ergebnis-bot self-requested a review July 12, 2020 14:34
@ergebnis-bot ergebnis-bot self-assigned this Jul 12, 2020
@ergebnis-bot ergebnis-bot merged commit d66c4f3 into main Jul 12, 2020
@ergebnis-bot ergebnis-bot deleted the fix/implements branch July 12, 2020 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants