Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Throw InvalidDefinition exception when definition can not be autoloaded #302

Merged
merged 1 commit into from
Jul 12, 2020

Conversation

localheinz
Copy link
Member

This PR

  • throws an InvalidDefinition exception when a potential definition can not be autoloaded

@localheinz localheinz self-assigned this Jul 12, 2020
@codecov
Copy link

codecov bot commented Jul 12, 2020

Codecov Report

Merging #302 into main will increase coverage by 0.72%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #302      +/-   ##
============================================
+ Coverage     98.56%   99.29%   +0.72%     
- Complexity      102      103       +1     
============================================
  Files            23       23              
  Lines           279      282       +3     
============================================
+ Hits            275      280       +5     
+ Misses            4        2       -2     
Impacted Files Coverage Δ Complexity Δ
src/Definitions.php 100.00% <100.00%> (+7.69%) 11.00 <0.00> (ø)
src/Exception/InvalidDefinition.php 100.00% <100.00%> (ø) 3.00 <1.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c029f9...88540fd. Read the comment docs.

@ergebnis-bot ergebnis-bot self-requested a review July 12, 2020 15:09
@ergebnis-bot ergebnis-bot self-assigned this Jul 12, 2020
@ergebnis-bot ergebnis-bot merged commit 16e9e93 into main Jul 12, 2020
@ergebnis-bot ergebnis-bot deleted the fix/throw branch July 12, 2020 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants