Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Rename Definition to EntityDefinitionProvider #314

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Conversation

localheinz
Copy link
Member

This PR

  • renames the Definition interface to EntityDefinitionProvider

@localheinz localheinz self-assigned this Jul 14, 2020
@codecov
Copy link

codecov bot commented Jul 14, 2020

Codecov Report

Merging #314 into main will increase coverage by 0.52%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #314      +/-   ##
============================================
+ Coverage     98.41%   98.93%   +0.52%     
- Complexity       98      101       +3     
============================================
  Files            21       22       +1     
  Lines           252      283      +31     
============================================
+ Hits            248      280      +32     
+ Misses            4        3       -1     
Impacted Files Coverage Δ Complexity Δ
src/Count.php 100.00% <100.00%> (ø) 8.00 <8.00> (?)
src/Exception/InvalidCount.php 100.00% <100.00%> (ø) 1.00 <1.00> (?)
src/Exception/InvalidDefinition.php 100.00% <100.00%> (ø) 3.00 <3.00> (+2.00)
src/Exception/InvalidMaximum.php 100.00% <100.00%> (ø) 1.00 <1.00> (?)
src/Exception/InvalidMinimum.php 100.00% <100.00%> (ø) 1.00 <1.00> (?)
src/FieldDefinition.php 100.00% <100.00%> (ø) 9.00 <1.00> (-2.00)
src/FieldDefinition/References.php 100.00% <100.00%> (ø) 2.00 <1.00> (ø)
src/FixtureFactory.php 97.85% <100.00%> (-0.38%) 48.00 <19.00> (+6.00) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33d6837...010b44a. Read the comment docs.

@ergebnis-bot ergebnis-bot self-requested a review July 14, 2020 16:14
@ergebnis-bot ergebnis-bot self-assigned this Jul 14, 2020
@ergebnis-bot ergebnis-bot merged commit ba31c2a into main Jul 14, 2020
@ergebnis-bot ergebnis-bot deleted the fix/rename branch July 14, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants