Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Re-enable final_class fixer #33

Merged
merged 4 commits into from
Mar 13, 2020
Merged

Fix: Re-enable final_class fixer #33

merged 4 commits into from
Mar 13, 2020

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Mar 13, 2020

This PR

  • re-enables the final_class fixer
  • runs make coding-standards
  • uses the real FixtureFactory in tests

Follows #1.

@localheinz localheinz added the bug label Mar 13, 2020
@localheinz localheinz self-assigned this Mar 13, 2020
@codecov
Copy link

codecov bot commented Mar 13, 2020

Codecov Report

Merging #33 into master will decrease coverage by 0.63%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #33      +/-   ##
============================================
- Coverage     61.85%   61.22%   -0.64%     
- Complexity       80       81       +1     
============================================
  Files             8        8              
  Lines           194      196       +2     
============================================
  Hits            120      120              
- Misses           74       76       +2
Impacted Files Coverage Δ Complexity Δ
src/FieldDef.php 0% <ø> (ø) 6 <0> (ø) ⬇️
src/EntityDef.php 0% <ø> (ø) 18 <0> (ø) ⬇️
src/FixtureFactory.php 91.56% <66.66%> (-2.27%) 37 <12> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c69f5c...400ed4d. Read the comment docs.

@localheinz localheinz mentioned this pull request Mar 13, 2020
1 task
@localheinz localheinz force-pushed the fix/final-class branch 2 times, most recently from 2188a7c to a1727fb Compare March 13, 2020 21:01
@localheinz localheinz marked this pull request as ready for review March 13, 2020 21:04
@localheinz localheinz force-pushed the fix/final-class branch 3 times, most recently from 0a8c726 to 59d2935 Compare March 13, 2020 22:35
@localheinz localheinz merged commit e5879dc into master Mar 13, 2020
@localheinz localheinz deleted the fix/final-class branch March 13, 2020 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant