Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Assemble exception messages using sprintf() #55

Merged
merged 1 commit into from
Mar 16, 2020

Conversation

localheinz
Copy link
Member

This PR

  • assembles exception messages using sprintf()

Follows #1.

@localheinz localheinz self-assigned this Mar 16, 2020
@codecov
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

Merging #55 into master will decrease coverage by 0.25%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #55      +/-   ##
============================================
- Coverage     93.78%   93.53%   -0.26%     
  Complexity       80       80              
============================================
  Files             8        8              
  Lines           193      201       +8     
============================================
+ Hits            181      188       +7     
- Misses           12       13       +1     
Impacted Files Coverage Δ Complexity Δ
src/FixtureFactory.php 91.11% <81.81%> (-0.56%) 37.00 <0.00> (ø)
src/EntityDef.php 95.23% <100.00%> (+0.23%) 17.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc746f1...56c0ddb. Read the comment docs.

@localheinz localheinz merged commit 66a9f9b into master Mar 16, 2020
@localheinz localheinz deleted the feature/sprintf branch March 16, 2020 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant