Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove unnecessary constructor parameter and field #56

Merged
merged 1 commit into from
Mar 16, 2020

Conversation

localheinz
Copy link
Member

This PR

  • removes an unnecessary constructor parameter and field from EntityDef

Follows #1.

@localheinz localheinz added the bug label Mar 16, 2020
@localheinz localheinz self-assigned this Mar 16, 2020
@codecov
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

Merging #56 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #56      +/-   ##
===========================================
- Coverage     93.53%   93.5%   -0.04%     
  Complexity       80      80              
===========================================
  Files             8       8              
  Lines           201     200       -1     
===========================================
- Hits            188     187       -1     
  Misses           13      13
Impacted Files Coverage Δ Complexity Δ
src/FixtureFactory.php 91.11% <ø> (ø) 37 <0> (ø) ⬇️
src/EntityDef.php 95.12% <100%> (-0.12%) 17 <1> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66a9f9b...5a04efd. Read the comment docs.

@localheinz localheinz merged commit e4ac3df into master Mar 16, 2020
@localheinz localheinz deleted the fix/type branch March 16, 2020 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant