Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Populate referenced embeddables #79

Merged
merged 2 commits into from
Mar 24, 2020
Merged

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Mar 24, 2020

This PR

  • asserts that referenced embeddables are populated
  • excludes fields using dot notation

@localheinz localheinz added the bug label Mar 24, 2020
@localheinz localheinz self-assigned this Mar 24, 2020
@localheinz localheinz marked this pull request as ready for review March 24, 2020 22:21
@codecov
Copy link

codecov bot commented Mar 24, 2020

Codecov Report

Merging #79 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #79      +/-   ##
============================================
+ Coverage     93.46%   93.53%   +0.06%     
  Complexity       76       76              
============================================
  Files             8        8              
  Lines           199      201       +2     
============================================
+ Hits            186      188       +2     
  Misses           13       13              
Impacted Files Coverage Δ Complexity Δ
src/EntityDef.php 95.55% <100.00%> (+0.20%) 13.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b261249...012bcc5. Read the comment docs.

@localheinz localheinz merged commit adaa3e0 into master Mar 24, 2020
@localheinz localheinz deleted the feature/embeddable branch March 24, 2020 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant