Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Sort extra fields #82

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Enhancement: Sort extra fields #82

merged 1 commit into from
Mar 26, 2020

Conversation

localheinz
Copy link
Member

This PR

  • sorts extra fields when attempting to get an instance from the fixture factory where field overrides reference fields not available in the entity

@localheinz localheinz self-assigned this Mar 26, 2020
@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #82 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #82      +/-   ##
============================================
+ Coverage     93.53%   93.56%   +0.03%     
  Complexity       76       76              
============================================
  Files             8        8              
  Lines           201      202       +1     
============================================
+ Hits            188      189       +1     
  Misses           13       13              
Impacted Files Coverage Δ Complexity Δ
src/FixtureFactory.php 90.90% <100.00%> (+0.10%) 37.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6288d73...6e49158. Read the comment docs.

@localheinz localheinz merged commit c2733dc into master Mar 26, 2020
@localheinz localheinz deleted the feature/sort branch March 26, 2020 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant