Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Throw InvalidFieldNames exception #87

Merged
merged 1 commit into from
Mar 28, 2020

Conversation

localheinz
Copy link
Member

This PR

  • throws a FieldsNotFound exception instead of a generic Exception when fields are referenced that are not found in the corresponding entity

@localheinz localheinz self-assigned this Mar 28, 2020
@codecov
Copy link

codecov bot commented Mar 28, 2020

Codecov Report

Merging #87 into master will increase coverage by 0.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #87      +/-   ##
============================================
+ Coverage     93.50%   93.77%   +0.27%     
- Complexity       75       77       +2     
============================================
  Files             8        9       +1     
  Lines           200      209       +9     
============================================
+ Hits            187      196       +9     
  Misses           13       13              
Impacted Files Coverage Δ Complexity Δ
src/EntityDef.php 95.45% <100.00%> (-0.11%) 13.00 <0.00> (ø)
src/Exception/InvalidFieldNames.php 100.00% <100.00%> (ø) 2.00 <2.00> (?)
src/FixtureFactory.php 90.80% <100.00%> (+0.10%) 36.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 320a5c3...458cfdb. Read the comment docs.

@localheinz localheinz marked this pull request as ready for review March 28, 2020 08:48
@localheinz localheinz force-pushed the feature/fields-not-found branch 6 times, most recently from 046eb57 to 1075942 Compare March 28, 2020 09:06
@localheinz localheinz changed the title Enhancement: Throw FieldsNotFound exception Enhancement: Throw InvalidFieldNames exception Mar 28, 2020
@localheinz localheinz merged commit be2cf7d into master Mar 28, 2020
@localheinz localheinz deleted the feature/fields-not-found branch March 28, 2020 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant