Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: No need to run build on PHP 7.2 twice #6

Merged
merged 1 commit into from
Jun 28, 2019
Merged

Fix: No need to run build on PHP 7.2 twice #6

merged 1 commit into from
Jun 28, 2019

Conversation

localheinz
Copy link
Member

This PR

  • stops running a test build on PHP 7.2 twice

@localheinz localheinz added the bug label Jun 28, 2019
@localheinz localheinz self-assigned this Jun 28, 2019
@szepeviktor
Copy link
Contributor

@localheinz Is it okay to use an interface's constant? RFC7231::CONNECT

@localheinz
Copy link
Member Author

@szepeviktor

Absolutely!

@localheinz localheinz merged commit ab7e944 into master Jun 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/matrix branch June 28, 2019 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@localheinz localheinz

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@localheinz @szepeviktor