Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Default to empty string as content type #132

Merged
merged 1 commit into from
Feb 22, 2019
Merged

Conversation

localheinz
Copy link
Member

This PR

  • defaults to an empty string as content type when ChainUriRetriever::retrieve() wasn't invoked yet, dropping the nullable return type declaration

@localheinz localheinz added the bug label Feb 20, 2019
@localheinz localheinz self-assigned this Feb 20, 2019
@codecov
Copy link

codecov bot commented Feb 20, 2019

Codecov Report

Merging #132 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #132   +/-   ##
=======================================
  Coverage       100%   100%           
+ Complexity      129    128    -1     
=======================================
  Files            30     30           
  Lines           404    404           
=======================================
  Hits            404    404
Impacted Files Coverage Δ Complexity Δ
...rc/JsonSchema/Uri/Retrievers/ChainUriRetriever.php 100% <100%> (ø) 6 <1> (-1) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fee48f5...b9ffb51. Read the comment docs.

@localheinz localheinz merged commit fda4072 into master Feb 22, 2019
@localheinz localheinz deleted the fix/content-type branch February 22, 2019 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant