Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Handle array where schema describes tuple #37

Merged
merged 1 commit into from
Feb 11, 2018

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Feb 11, 2018

This PR

  • handles array where schema describes a tuple

💁‍♂️ Currently we only handle arrays where the item schema describes a list (where each item follows the same schema).

@codecov
Copy link

codecov bot commented Feb 11, 2018

Codecov Report

Merging #37 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #37   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity      106    106           
=======================================
  Files            13     13           
  Lines           279    283    +4     
=======================================
+ Hits            279    283    +4
Impacted Files Coverage Δ Complexity Δ
src/SchemaNormalizer.php 100% <100%> (ø) 40 <5> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5975e9c...11f3462. Read the comment docs.

@localheinz localheinz force-pushed the feature/tuple branch 4 times, most recently from 788f426 to 88d0786 Compare February 11, 2018 14:34
@localheinz localheinz merged commit ce8e90c into master Feb 11, 2018
@localheinz localheinz deleted the feature/tuple branch February 11, 2018 14:41
localheinz added a commit that referenced this pull request Feb 11, 2018
Enhancement: Handle array where schema describes tuple
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant