Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Let ConfigHashNormalizer normalize other properties when property is empty #423

Merged
merged 2 commits into from
Dec 29, 2020

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Dec 29, 2020

This PR

  • asserts that the ConfigHashNormalizer normalizes other properties when a property is empty
  • continues to normalizes other properties when a property is empty

@codecov
Copy link

codecov bot commented Dec 29, 2020

Codecov Report

Merging #423 (4cc8b6d) into main (6b5d8c6) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##                main      #423   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       161       161           
===========================================
  Files             34        34           
  Lines            500       500           
===========================================
  Hits             500       500           
Impacted Files Coverage Δ Complexity Δ
src/Vendor/Composer/ConfigHashNormalizer.php 100.00% <100.00%> (ø) 5.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b5d8c6...4cc8b6d. Read the comment docs.

@ergebnis-bot ergebnis-bot self-assigned this Dec 29, 2020
@ergebnis-bot ergebnis-bot merged commit 55e2515 into main Dec 29, 2020
@ergebnis-bot ergebnis-bot deleted the fix/continue branch December 29, 2020 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants