Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use property path instead of property name to exclude property #429

Merged
merged 2 commits into from
Dec 31, 2020

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Dec 31, 2020

This PR

  • asserts that other properties with the name preferred-install, and a possibly different meaning, are sorted
  • adjusts the ConfigHashNormalizer to take the property path into account, not the property name

Follows #425.

@localheinz localheinz self-assigned this Dec 31, 2020
@localheinz localheinz marked this pull request as draft December 31, 2020 09:23
@codecov
Copy link

codecov bot commented Dec 31, 2020

Codecov Report

Merging #429 (dd8056c) into main (362d3e1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##                main      #429   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       164       164           
===========================================
  Files             34        34           
  Lines            512       514    +2     
===========================================
+ Hits             512       514    +2     
Impacted Files Coverage Δ Complexity Δ
src/Vendor/Composer/ConfigHashNormalizer.php 100.00% <100.00%> (ø) 8.00 <4.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 362d3e1...dd8056c. Read the comment docs.

@ergebnis-bot ergebnis-bot self-assigned this Dec 31, 2020
ergebnis-bot
ergebnis-bot previously approved these changes Dec 31, 2020
@localheinz localheinz marked this pull request as ready for review December 31, 2020 09:25
@ergebnis-bot ergebnis-bot merged commit 6da58f6 into main Dec 31, 2020
@ergebnis-bot ergebnis-bot deleted the fix/path branch December 31, 2020 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants