Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Sniff new-line character sequence #55

Merged
merged 2 commits into from
Apr 7, 2018

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Apr 6, 2018

This PR

  • updates localheinz/json-printer
  • sniffs and prints using sniffed new-line character sequence

Related to ergebnis/composer-normalize#58.

💁‍♂️ For reference, see ergebnis/json-printer@1.1.0...2.0.0

@localheinz localheinz self-assigned this Apr 6, 2018
@codecov
Copy link

codecov bot commented Apr 6, 2018

Codecov Report

Merging #55 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #55   +/-   ##
=======================================
  Coverage       100%   100%           
- Complexity      104    110    +6     
=======================================
  Files            13     13           
  Lines           294    315   +21     
=======================================
+ Hits            294    315   +21
Impacted Files Coverage Δ Complexity Δ
src/Format/Formatter.php 100% <100%> (ø) 6 <0> (ø) ⬇️
src/Format/Format.php 100% <100%> (ø) 15 <7> (+4) ⬆️
src/Format/Sniffer.php 100% <100%> (ø) 12 <2> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25e87ce...bdb1256. Read the comment docs.

@localheinz localheinz merged commit f280f0b into master Apr 7, 2018
@localheinz localheinz deleted the feature/new-line branch April 7, 2018 08:03
@localheinz
Copy link
Member Author

Thank you, @xtreamwayz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants