Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove JsonInterface #92

Merged
merged 1 commit into from
Oct 5, 2018
Merged

Fix: Remove JsonInterface #92

merged 1 commit into from
Oct 5, 2018

Conversation

localheinz
Copy link
Member

This PR

  • removes the JsonInterface

Follows #89.

💁‍♂️ There's no need for a different implementation.

@localheinz localheinz added the bug label Oct 5, 2018
@localheinz localheinz self-assigned this Oct 5, 2018
@localheinz localheinz force-pushed the fix/json branch 3 times, most recently from e49584e to d659b02 Compare October 5, 2018 21:30
@codecov
Copy link

codecov bot commented Oct 5, 2018

Codecov Report

Merging #92 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #92   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity      126    126           
=======================================
  Files            27     27           
  Lines           390    390           
=======================================
  Hits            390    390
Impacted Files Coverage Δ Complexity Δ
src/SchemaNormalizer.php 100% <100%> (ø) 34 <7> (ø) ⬇️
src/FixedFormatNormalizer.php 100% <100%> (ø) 3 <1> (ø) ⬇️
src/NoFinalNewLineNormalizer.php 100% <100%> (ø) 1 <1> (ø) ⬇️
src/CallableNormalizer.php 100% <100%> (ø) 2 <1> (ø) ⬇️
src/Format/Formatter.php 100% <100%> (ø) 4 <2> (ø) ⬇️
src/IndentNormalizer.php 100% <100%> (ø) 3 <1> (ø) ⬇️
src/Json.php 100% <100%> (ø) 9 <3> (ø) ⬇️
src/Format/Format.php 100% <100%> (ø) 21 <1> (ø) ⬇️
src/FinalNewLineNormalizer.php 100% <100%> (ø) 1 <1> (ø) ⬇️
src/ChainNormalizer.php 100% <100%> (ø) 3 <2> (ø) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c99df9...267ae6b. Read the comment docs.

@localheinz localheinz force-pushed the fix/json branch 2 times, most recently from 4de710c to 0224278 Compare October 5, 2018 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant