Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Always decode JSON to object #3

Merged
merged 2 commits into from
Dec 10, 2022
Merged

Fix: Always decode JSON to object #3

merged 2 commits into from
Dec 10, 2022

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Dec 10, 2022

This pull request

  • asserts that JSON is consistently decoded to an object
  • consistently uses false as argument for the $associative parameter when json_decode()ing a JSON string

@codecov
Copy link

codecov bot commented Dec 10, 2022

Codecov Report

Merging #3 (8be5d6f) into main (b3e8d07) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main       #3   +/-   ##
=========================================
  Coverage     96.66%   96.66%           
  Complexity       14       14           
=========================================
  Files             5        5           
  Lines            30       30           
=========================================
  Hits             29       29           
  Misses            1        1           
Impacted Files Coverage Δ
src/Json.php 95.45% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@localheinz localheinz changed the title Enhancement: Assert that JSON is consistently decoded to an object Fix: Always decode JSON to object Dec 10, 2022
@localheinz localheinz merged commit 7c0a1e3 into main Dec 10, 2022
@localheinz localheinz deleted the fix/object branch December 10, 2022 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants