Merge pull request #26 from ergebnis/fix/iterable

Fix: Do not bother checking iterable type
ergebnis · Dec 23, 2019 · 9ff8772 · 9ff8772
2 parents 19b01f5 + 30265a4
commit 9ff8772
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 16 deletions.
diff --git a/phpstan.neon b/phpstan.neon
@@ -2,6 +2,7 @@ includes:
 	- phpstan-baseline.neon
 
 parameters:
+	checkMissingIterableValueType: false
 	ergebnis:
 		classesAllowedToBeExtended:
 			- Ergebnis\PhpCsFixer\Config\RuleSet\AbstractRuleSet

diff --git a/src/Factory.php b/src/Factory.php
@@ -21,7 +21,7 @@ final class Factory
      * Creates a configuration based on a rule set.
      *
      * @param RuleSet $ruleSet
-     * @param array<string, bool|array<string, bool|string>> $overrideRules
+     * @param array $overrideRules
      *
      * @throws \RuntimeException
      *

diff --git a/src/RuleSet.php b/src/RuleSet.php
@@ -25,7 +25,7 @@ public function name(): string;
     /**
      * Returns an array of rules along with their configuration.
      *
-     * @return array<string, bool|array<string, bool|string>>
+     * @return array
      */
     public function rules(): array;
 

diff --git a/src/RuleSet/AbstractRuleSet.php b/src/RuleSet/AbstractRuleSet.php
@@ -26,7 +26,7 @@ abstract class AbstractRuleSet implements RuleSet
     protected $name;
 
     /**
-     * @var array<string, bool|array<string, bool|string>>
+     * @var array
      */
     protected $rules = [];
 

diff --git a/test/Unit/FactoryTest.php b/test/Unit/FactoryTest.php
@@ -101,9 +101,6 @@ public function testFromRuleSetCreatesConfig(int $targetPhpVersion): void
         self::assertSame($rules, $config->getRules());
     }
 
-    /**
-     * @return \Generator<array<int>>
-     */
     public function providerTargetPhpVersion(): \Generator
     {
         $values = [

diff --git a/test/Unit/RuleSet/AbstractRuleSetTestCase.php b/test/Unit/RuleSet/AbstractRuleSetTestCase.php
@@ -30,7 +30,7 @@ abstract class AbstractRuleSetTestCase extends Framework\TestCase
     protected $name;
 
     /**
-     * @var array<string, bool|array<string, bool|string>>
+     * @var array
      */
     protected $rules;
 
@@ -107,9 +107,6 @@ final public function testHeaderCommentFixerIsEnabledIfHeaderIsProvided($header)
         self::assertSame($expected, $rules['header_comment']);
     }
 
-    /**
-     * @return \Generator<array<string>>
-     */
     final public function providerValidHeader(): \Generator
     {
         $values = [
@@ -145,9 +142,6 @@ final public function testRulesAreSortedByName(string $source, array $ruleNames)
         ));
     }
 
-    /**
-     * @return \Generator<array{0: string, 1: array<int, string>}>
-     */
     final public function providerRuleNames(): \Generator
     {
         $values = [
@@ -235,9 +229,6 @@ private function builtInFixers(): array
         return $builtInFixers;
     }
 
-    /**
-     * @return array<int, int|string>
-     */
     private function configuredFixers(): array
     {
         /**