Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Extract Name as value object #870

Merged
merged 1 commit into from Sep 16, 2023
Merged

Enhancement: Extract Name as value object #870

merged 1 commit into from Sep 16, 2023

Conversation

localheinz
Copy link
Member

This pull request

  • extracts Name as a value object

@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Merging #870 (bf4d590) into main (ad0e96d) will increase coverage by 0.49%.
The diff coverage is 93.93%.

@@             Coverage Diff              @@
##               main     #870      +/-   ##
============================================
+ Coverage     93.68%   94.17%   +0.49%     
- Complexity       40       44       +4     
============================================
  Files            14       15       +1     
  Lines            95      103       +8     
============================================
+ Hits             89       97       +8     
  Misses            6        6              
Files Changed Coverage Δ
src/RuleSet/Php82.php 0.00% <0.00%> (ø)
src/Factory.php 100.00% <100.00%> (ø)
src/Name.php 100.00% <100.00%> (ø)
src/RuleSet/Php53.php 100.00% <100.00%> (ø)
src/RuleSet/Php54.php 100.00% <100.00%> (ø)
src/RuleSet/Php55.php 100.00% <100.00%> (ø)
src/RuleSet/Php56.php 100.00% <100.00%> (ø)
src/RuleSet/Php70.php 100.00% <100.00%> (ø)
src/RuleSet/Php71.php 100.00% <100.00%> (ø)
src/RuleSet/Php72.php 100.00% <100.00%> (ø)
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@localheinz localheinz marked this pull request as ready for review September 16, 2023 09:13
@localheinz localheinz changed the title Enhancement: Extract Name as value object Enhancement: Extract Name as value object Sep 16, 2023
@localheinz localheinz merged commit 5a49af4 into main Sep 16, 2023
15 checks passed
@localheinz localheinz deleted the feature/name branch September 16, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants