Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Implement Expressions\NoCompactRule #116

Merged
merged 1 commit into from
Sep 5, 2019

Conversation

localheinz
Copy link
Member

This PR

  • implements an Expressions\NoCompactRule, which reports an error when the function compact() is used

@codecov
Copy link

codecov bot commented Sep 5, 2019

Codecov Report

Merging #116 into master will decrease coverage by 0.86%.
The diff coverage is 61.53%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #116      +/-   ##
============================================
- Coverage     84.19%   83.33%   -0.87%     
- Complexity       97      102       +5     
============================================
  Files            17       18       +1     
  Lines           329      342      +13     
============================================
+ Hits            277      285       +8     
- Misses           52       57       +5
Impacted Files Coverage Δ Complexity Δ
src/Expressions/NoCompactRule.php 61.53% <61.53%> (ø) 5 <5> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 749b493...b69afa7. Read the comment docs.

@localheinz localheinz merged commit a85eeb8 into master Sep 5, 2019
@localheinz localheinz deleted the feature/compact branch September 5, 2019 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant