Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Implement Methods\PrivateInFinalClassRule #126

Merged
merged 1 commit into from
Oct 15, 2019

Conversation

localheinz
Copy link
Member

This PR

  • implements a Methods\PrivateInFinalClassRule which reports an error when a method in a final class is protected when it could be `private

@localheinz localheinz self-assigned this Sep 14, 2019
@codecov
Copy link

codecov bot commented Sep 14, 2019

Codecov Report

Merging #126 into master will decrease coverage by <.01%.
The diff coverage is 84%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #126      +/-   ##
============================================
- Coverage     84.12%   84.11%   -0.01%     
- Complexity      125      134       +9     
============================================
  Files            21       22       +1     
  Lines           422      447      +25     
============================================
+ Hits            355      376      +21     
- Misses           67       71       +4
Impacted Files Coverage Δ Complexity Δ
src/Methods/PrivateInFinalClassRule.php 84% <84%> (ø) 9 <9> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfcbc79...3431c0e. Read the comment docs.

@localheinz localheinz force-pushed the feature/methods-private-in-final-class branch 2 times, most recently from 07e26a9 to 0d00b55 Compare September 15, 2019 16:14
@localheinz localheinz force-pushed the feature/methods-private-in-final-class branch from 0d00b55 to 3431c0e Compare September 15, 2019 16:24
@localheinz localheinz merged commit 27bac8c into master Oct 15, 2019
@localheinz localheinz deleted the feature/methods-private-in-final-class branch October 15, 2019 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant