Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Do not report about not declared strict types if file begins with shebang #186

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Fix: Do not report about not declared strict types if file begins with shebang #186

merged 1 commit into from
Jan 28, 2020

Conversation

Great-Antique
Copy link
Contributor

This PR removes File is missing a "declare(strict_types=1)" declaration. errors if file begins with shebang (e.g. #!/usr/bin/env php).

localheinz
localheinz previously approved these changes Jan 28, 2020
Copy link
Member

@localheinz localheinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@localheinz localheinz changed the title Enhancement: Do not report about not declared strict types if file begins with shebang Fix: Do not report about not declared strict types if file begins with shebang Jan 28, 2020
@localheinz localheinz merged commit e5218ab into ergebnis:master Jan 28, 2020
@localheinz
Copy link
Member

Thank you, @Great-Antique!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants