Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Implement Closures\NoParameterWithNullDefaultValueRule #26

Merged
merged 1 commit into from
Nov 24, 2018

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Nov 21, 2018

This PR

  • implements Closures\NoParameterWithNullDefaultValueRule, which reports an error when a closure has a parameter with null as default value

@localheinz localheinz self-assigned this Nov 21, 2018
@localheinz localheinz force-pushed the feature/no-null-default-value branch 2 times, most recently from 162e64b to 035cdc8 Compare November 21, 2018 21:14
@codecov
Copy link

codecov bot commented Nov 21, 2018

Codecov Report

Merging #26 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #26   +/-   ##
=======================================
  Coverage       100%   100%           
- Complexity       24     29    +5     
=======================================
  Files             5      6    +1     
  Lines            56     73   +17     
=======================================
+ Hits             56     73   +17
Impacted Files Coverage Δ Complexity Δ
...c/Closures/NoParameterWithNullDefaultValueRule.php 100% <100%> (ø) 5 <5> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 244a35f...13c5372. Read the comment docs.

@localheinz localheinz force-pushed the feature/no-null-default-value branch 3 times, most recently from 850139b to ac220a0 Compare November 23, 2018 18:49
@localheinz localheinz changed the title Enhancement: Implement NoNullDefaultValueRule Enhancement: Implement NoParameterWithNullDefaultValueRule Nov 23, 2018
@localheinz localheinz force-pushed the feature/no-null-default-value branch 4 times, most recently from 1eefdba to c1a0f06 Compare November 24, 2018 13:39
@localheinz localheinz changed the title Enhancement: Implement NoParameterWithNullDefaultValueRule Enhancement: Implement Closures\NoParameterWithNullDefaultValueRule Nov 24, 2018
@localheinz localheinz merged commit 952f35b into master Nov 24, 2018
@localheinz localheinz deleted the feature/no-null-default-value branch November 24, 2018 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant