Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Implement Functions\NoParameterWithNullDefaultValueRule #31

Merged

Conversation

localheinz
Copy link
Member

This PR

  • implements Functions\NoParameterWithNullDefaultValueRule, which reports an error when a function has a parameter with null as default value

@localheinz localheinz self-assigned this Nov 24, 2018
@codecov
Copy link

codecov bot commented Nov 24, 2018

Codecov Report

Merging #31 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #31   +/-   ##
=======================================
  Coverage       100%   100%           
- Complexity       29     34    +5     
=======================================
  Files             6      7    +1     
  Lines            73     92   +19     
=======================================
+ Hits             73     92   +19
Impacted Files Coverage Δ Complexity Δ
.../Functions/NoParameterWithNullDefaultValueRule.php 100% <100%> (ø) 5 <5> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 952f35b...07b4758. Read the comment docs.

@localheinz localheinz force-pushed the feature/functions-no-parameter-with-null-default-value branch from 391c992 to 16a3038 Compare November 24, 2018 15:19
@localheinz localheinz force-pushed the feature/functions-no-parameter-with-null-default-value branch from 16a3038 to 07b4758 Compare November 24, 2018 15:20
@localheinz localheinz merged commit c2ac1ec into master Nov 24, 2018
@localheinz localheinz deleted the feature/functions-no-parameter-with-null-default-value branch November 24, 2018 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant