Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Implement Methods\NoParameterWithNullDefaultValueRule #32

Merged

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Nov 24, 2018

This PR

  • implements Methods\NoParameterWithNullDefaultValueRule, which reports an error when a method declared in an anonymous class, a class, or an interface has a parameter with null as default value

@localheinz localheinz self-assigned this Nov 24, 2018
@codecov
Copy link

codecov bot commented Nov 24, 2018

Codecov Report

Merging #32 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #32   +/-   ##
=======================================
  Coverage       100%   100%           
- Complexity       34     40    +6     
=======================================
  Files             7      8    +1     
  Lines            92    122   +30     
=======================================
+ Hits             92    122   +30
Impacted Files Coverage Δ Complexity Δ
...rc/Methods/NoParameterWithNullDefaultValueRule.php 100% <100%> (ø) 6 <6> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2ac1ec...160d5a6. Read the comment docs.

@localheinz localheinz force-pushed the feature/methods-no-parameter-with-null-default-value branch from c6364ae to 0fd1be3 Compare November 24, 2018 15:45
@localheinz localheinz force-pushed the feature/methods-no-parameter-with-null-default-value branch from 0fd1be3 to 160d5a6 Compare November 24, 2018 16:00
@localheinz localheinz merged commit 161caaa into master Nov 24, 2018
@localheinz localheinz deleted the feature/methods-no-parameter-with-null-default-value branch November 24, 2018 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant