Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Implement Closures\NoParameterWithNullableTypeDeclarationRule #33

Merged

Conversation

localheinz
Copy link
Member

This PR

  • implements Closures\NoParameterWithNullableTypeDeclarationRule, which reports an error when a closure has a parameter with a nullable type declaration

@localheinz localheinz self-assigned this Nov 24, 2018
@codecov
Copy link

codecov bot commented Nov 24, 2018

Codecov Report

Merging #33 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #33   +/-   ##
=======================================
  Coverage       100%   100%           
- Complexity       40     44    +4     
=======================================
  Files             8      9    +1     
  Lines           122    137   +15     
=======================================
+ Hits            122    137   +15
Impacted Files Coverage Δ Complexity Δ
...res/NoParameterWithNullableTypeDeclarationRule.php 100% <100%> (ø) 4 <4> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 161caaa...f5263d6. Read the comment docs.

@localheinz localheinz force-pushed the feature/closure-no-parameter-with-nullable-type-declaration branch from 90c8774 to f5263d6 Compare November 24, 2018 16:13
@localheinz localheinz merged commit 3e9ca63 into master Nov 24, 2018
@localheinz localheinz deleted the feature/closure-no-parameter-with-nullable-type-declaration branch November 24, 2018 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant