Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove double-quotes from error messages #39

Merged
merged 1 commit into from
Dec 3, 2018
Merged

Conversation

localheinz
Copy link
Member

This PR

  • removes double-quotes from error message to be more consistent with the format of error messages produced by phpstan/phpstan

@localheinz localheinz added the bug label Dec 2, 2018
@localheinz localheinz self-assigned this Dec 2, 2018
@codecov
Copy link

codecov bot commented Dec 2, 2018

Codecov Report

Merging #39 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #39   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity       53     53           
=======================================
  Files            11     11           
  Lines           182    182           
=======================================
  Hits            182    182
Impacted Files Coverage Δ Complexity Δ
...rc/Methods/NoParameterWithNullDefaultValueRule.php 100% <100%> (ø) 6 <0> (ø) ⬇️
...res/NoParameterWithNullableTypeDeclarationRule.php 100% <100%> (ø) 4 <0> (ø) ⬇️
.../Functions/NoParameterWithNullDefaultValueRule.php 100% <100%> (ø) 5 <0> (ø) ⬇️
...ods/NoParameterWithNullableTypeDeclarationRule.php 100% <100%> (ø) 5 <0> (ø) ⬇️
src/Classes/AbstractOrFinalRule.php 100% <100%> (ø) 7 <0> (ø) ⬇️
...c/Closures/NoParameterWithNullDefaultValueRule.php 100% <100%> (ø) 5 <0> (ø) ⬇️
src/Classes/FinalRule.php 100% <100%> (ø) 6 <0> (ø) ⬇️
.../Functions/NoNullableReturnTypeDeclarationRule.php 100% <100%> (ø) 4 <0> (ø) ⬇️
...ons/NoParameterWithNullableTypeDeclarationRule.php 100% <100%> (ø) 4 <0> (ø) ⬇️
...rc/Methods/NoNullableReturnTypeDeclarationRule.php 100% <100%> (ø) 4 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9220278...0599eb7. Read the comment docs.

@localheinz localheinz merged commit 72513ee into master Dec 3, 2018
@localheinz localheinz deleted the fix/message branch December 3, 2018 07:13
@localheinz localheinz mentioned this pull request Dec 3, 2018
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant