Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Adjust Classes\FinalRule to inspect attributes #395

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

localheinz
Copy link
Member

This pull request

  • adjusts Classes\FinalRule to also inspect attributes

Fixes #364.

@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #395 (21040cd) into main (e1d0346) will decrease coverage by 0.46%.
The diff coverage is 40.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #395      +/-   ##
============================================
- Coverage     83.93%   83.46%   -0.47%     
- Complexity      151      154       +3     
============================================
  Files            23       23              
  Lines           498      502       +4     
============================================
+ Hits            418      419       +1     
- Misses           80       83       +3     
Impacted Files Coverage Δ
src/Classes/FinalRule.php 81.81% <40.00%> (-5.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1d0346...21040cd. Read the comment docs.

@localheinz localheinz added bug and removed enhancement labels Nov 8, 2021
@localheinz localheinz merged commit 0e067cc into main Nov 8, 2021
@localheinz localheinz deleted the feature/attribute branch November 8, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Whitelist PHP 8 Attribute #[ORM\Entity]
2 participants