Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Implement FinalRule #4

Merged
merged 1 commit into from
Nov 13, 2018
Merged

Enhancement: Implement FinalRule #4

merged 1 commit into from
Nov 13, 2018

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Nov 13, 2018

This PR

  • implements a FinalRule, which reports an error when a non-anonymous class is not final

@localheinz localheinz self-assigned this Nov 13, 2018
@codecov
Copy link

codecov bot commented Nov 13, 2018

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master     #4   +/-   ##
=======================================
  Coverage       100%   100%           
- Complexity        5      9    +4     
=======================================
  Files             1      2    +1     
  Lines            10     18    +8     
=======================================
+ Hits             10     18    +8
Impacted Files Coverage Δ Complexity Δ
src/Classes/FinalRule.php 100% <100%> (ø) 4 <4> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c47f18...6d13968. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant