Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Update localheinz/php-cs-fixer-config #64

Merged
merged 3 commits into from
Jan 5, 2019

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Jan 4, 2019

This PR

  • updates localheinz/php-cs-fixer-config
  • runs make cs
  • does not remove localheinz/php-cs-fixer-config on PHP 7.3

💁‍♂️ For reference, see localheinz/php-cs-fixer-config@1.17.0...1.19.0.

@localheinz localheinz self-assigned this Jan 4, 2019
@codecov
Copy link

codecov bot commented Jan 5, 2019

Codecov Report

Merging #64 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #64   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity       55     55           
=======================================
  Files            11     11           
  Lines           201    201           
=======================================
  Hits            201    201
Impacted Files Coverage Δ Complexity Δ
...rc/Methods/NoParameterWithNullDefaultValueRule.php 100% <ø> (ø) 6 <0> (ø) ⬇️
...res/NoParameterWithNullableTypeDeclarationRule.php 100% <ø> (ø) 4 <0> (ø) ⬇️
...ods/NoParameterWithNullableTypeDeclarationRule.php 100% <ø> (ø) 5 <0> (ø) ⬇️
...rc/Methods/NoNullableReturnTypeDeclarationRule.php 100% <ø> (ø) 4 <0> (ø) ⬇️
.../Functions/NoParameterWithNullDefaultValueRule.php 100% <ø> (ø) 5 <0> (ø) ⬇️
...ods/NoConstructorParameterWithDefaultValueRule.php 100% <ø> (ø) 6 <0> (ø) ⬇️
.../Functions/NoNullableReturnTypeDeclarationRule.php 100% <ø> (ø) 4 <0> (ø) ⬇️
...c/Closures/NoNullableReturnTypeDeclarationRule.php 100% <ø> (ø) 3 <0> (ø) ⬇️
...c/Closures/NoParameterWithNullDefaultValueRule.php 100% <ø> (ø) 5 <0> (ø) ⬇️
...ons/NoParameterWithNullableTypeDeclarationRule.php 100% <ø> (ø) 4 <0> (ø) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6c4b66...1381c2b. Read the comment docs.

@localheinz localheinz merged commit 58fae63 into master Jan 5, 2019
@localheinz localheinz deleted the feature/php-cs-fixer-config branch January 5, 2019 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant