Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Adjust Classes\FinalRule to ignore Doctrine entities #84

Merged
merged 1 commit into from
May 7, 2019

Conversation

localheinz
Copy link
Member

This PR

  • adjusts Classes\FinalRule to ignore Doctrine entities

Fixes #78.

馃拋鈥嶁檪 Inspired by the work on PhpCsFixer\Fixer\ClassNotation\FinalClassFixer and PhpCsFixer\Fixer\ClassNotation\FinalInternalClassFixer, contributed by @keradus, @Slamdunk, and @SpacePossum for friendsofphp/php-cs-fixer.

@codecov
Copy link

codecov bot commented May 7, 2019

Codecov Report

Merging #84 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #84   +/-   ##
=======================================
  Coverage       100%   100%           
- Complexity       63     70    +7     
=======================================
  Files            13     13           
  Lines           226    238   +12     
=======================================
+ Hits            226    238   +12
Impacted Files Coverage 螖 Complexity 螖
src/Classes/FinalRule.php 100% <100%> (酶) 16 <6> (+7) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update f5a704c...8e94b35. Read the comment docs.

@localheinz localheinz force-pushed the feature/final-rule-doctrine branch from 46efcff to 8e94b35 Compare May 7, 2019 05:42
@localheinz localheinz merged commit 6d6298c into master May 7, 2019
@localheinz localheinz deleted the feature/final-rule-doctrine branch May 7, 2019 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exclude Doctrine Entities from the FinalRule
1 participant