Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Require at least phpstan/phpstan:~0.11.7 #91

Merged
merged 2 commits into from
May 22, 2019

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented May 22, 2019

This PR

  • requires at least phpstan/phpstan:~0.11.7
  • fixes issues reported via static analysis

@localheinz localheinz self-assigned this May 22, 2019
@codecov
Copy link

codecov bot commented May 22, 2019

Codecov Report

Merging #91 into master will decrease coverage by 16.1%.
The diff coverage is 20%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master      #91       +/-   ##
=============================================
- Coverage       100%   83.89%   -16.11%     
- Complexity       70       82       +12     
=============================================
  Files            13       13               
  Lines           238      298       +60     
=============================================
+ Hits            238      250       +12     
- Misses            0       48       +48
Impacted Files Coverage Δ Complexity Δ
...rc/Methods/NoNullableReturnTypeDeclarationRule.php 80% <20%> (-20%) 5 <0> (+1)
...rc/Methods/NoParameterWithNullDefaultValueRule.php 88.57% <20%> (-11.43%) 7 <0> (+1)
...res/NoParameterWithNullableTypeDeclarationRule.php 80% <20%> (-20%) 5 <0> (+1)
src/Classes/NoExtendsRule.php 84.61% <20%> (-15.39%) 7 <0> (+1)
...ods/NoConstructorParameterWithDefaultValueRule.php 87.5% <20%> (-12.5%) 7 <0> (+1)
...ods/NoParameterWithNullableTypeDeclarationRule.php 87.87% <20%> (-12.13%) 6 <0> (+1)
...c/Closures/NoParameterWithNullDefaultValueRule.php 81.81% <20%> (-18.19%) 6 <0> (+1)
.../Functions/NoParameterWithNullDefaultValueRule.php 83.33% <20%> (-16.67%) 6 <0> (+1)
.../Functions/NoNullableReturnTypeDeclarationRule.php 69.23% <20%> (-30.77%) 5 <0> (+1)
...ons/NoParameterWithNullableTypeDeclarationRule.php 81.81% <20%> (-18.19%) 5 <0> (+1)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a254273...01350d2. Read the comment docs.

@localheinz localheinz force-pushed the feature/phpstan branch 2 times, most recently from a3a597a to e6e6611 Compare May 22, 2019 15:21
@localheinz localheinz merged commit b351a18 into master May 22, 2019
@localheinz localheinz deleted the feature/phpstan branch May 22, 2019 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant