Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add support for phpunit/phpunit:^11.0.0 #485

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

localheinz
Copy link
Member

This pull request

  • adds support for phpunit/phpunit:^11.0.0

Fixes #424.

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eb449d3) 74.46% compared to head (79c3129) 74.46%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #485   +/-   ##
=========================================
  Coverage     74.46%   74.46%           
  Complexity      110      110           
=========================================
  Files            26       26           
  Lines           470      470           
=========================================
  Hits            350      350           
  Misses          120      120           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@localheinz localheinz force-pushed the feature/phpunit-11 branch 3 times, most recently from 4e32e44 to 1beb735 Compare February 2, 2024 20:27
- context: "Tests (11.0.0, 8.2, lowest)"
- context: "Tests (11.0.0, 8.2, highest)"
- context: "Tests (11.0.0, 8.3, highest)"
- context: "Tests (11.0.0, 8.3, lowest)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to keep testing with the latest PHPUnit main/11.1.x

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

Yet i tḧink that should be kept in another PR tbh 😄

@localheinz localheinz force-pushed the feature/phpunit-11 branch 2 times, most recently from 4c84ae6 to 79c3129 Compare February 4, 2024 11:53
@negoziator
Copy link

@localheinz Isn't this ready to merge ? 🤔

@localheinz localheinz force-pushed the feature/phpunit-11 branch 2 times, most recently from 1e6f13c to d9b8fa4 Compare February 5, 2024 15:06
@localheinz localheinz merged commit c5bc65e into main Feb 5, 2024
39 checks passed
@localheinz localheinz deleted the feature/phpunit-11 branch February 5, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for phpunit/phpunit:^11.0.0
4 participants