Support for certfp migration in 2json scripts

[tacerus]

Hi,

amongst the data migrated in the anope2json and atheme2json scripts (which have come very handy in the past!) are NickServ passwords. Since some users utilize certfp for authentication however, it would be great if the associated fingerprints were included in the migration.

Here is a sample snippet from an Anope database:

OBJECT NickCore
ID 172
DATA display foo    
DATA pass sha1:xxxxxxxxxxxxxx                          
DATA email foo@example.com   
DATA language
DATA access foo@*.example.com    
DATA memomax 20
DATA MEMO_SIGNON 1
DATA MEMO_RECEIVE 1
DATA cert UzScAKbIfiAlkBhpcnNPhpZiH7ZXt4C7RHOwpsfQHFmCNkwaBFWbEWUnUDtnW57x 
DATA HIDE_EMAIL 1
DATA HIDE_MASK 1
DATA NS_PRIVATE 1
DATA AUTOOP 1
DATA NS_SECURE 1
END

Unfortunately I do not have an Atheme one handy.

Thanks for considering.

[slingamn]

Right, I remember discussing this with @jlu5 : one of the problems is that the hash algorithm used to produce the fingerprint is not stored in band.

The fingerprint there looks like base64, but assuming it is, it decodes to 384 bits --- what algorithm is that? If it's anything other than SHA-256, it's useless to us.

[tacerus]

That one is SHA256. I think it's the standard for Anope.

[slingamn]

Resolution: if we see a DATA cert line in anope and the parameter is 64 bytes of hex (i.e. 256 bits encoded as hex), we'll attempt to interpret it as a SHA-256 fingerprint.

Does anyone know how atheme handles this?

[slingamn]

Relevant Atheme code:

https://github.com/atheme/atheme/blob/82866a59bef5f1be76f3b9d16b7016f04a3791e4/modules/backend/corestorage.c#L151-L159

[slingamn]

In the database, it looks like:

MCFP certtest 3d6b11bfb405c3f84b38cd3038fbec0171d50354790407884ca55d23418566c9 

including a final space?