Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sanitize in-band error message from /rehash #2031

Closed
slingamn opened this issue Jan 10, 2023 · 0 comments
Closed

sanitize in-band error message from /rehash #2031

slingamn opened this issue Jan 10, 2023 · 0 comments
Labels
bug
Milestone
v2.12.0

Comments

@slingamn
Copy link
Member

@eskimo reports the following error from a failed rehash (YAML syntax error):

Message(400): Error assembling message for sending

We should be using ircutils.SanitizeText on the error. Also 400 ERR_UNKNOWNERROR is fake, we should just send a FAIL.
@slingamn slingamn added the bug label Jan 10, 2023
@slingamn slingamn added this to the v2.12.0 milestone Jan 10, 2023
slingamn added a commit that referenced this issue Jan 15, 2023
@slingamn
Merge pull request #2033 from slingamn/rehash
177133a 
fix #2031
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v2.12.0
Development

No branches or pull requests
1 participant
@slingamn