Ergo sending BATCH to the client without previous negotiation

[julio-b]

Steps to reproduce

request draft/chathistory but do not request batch

Actual behavior

trimmed down a bit

C: CAP REQ :draft/chathistory
...
C: CHATHISTORY TARGETS timestamp=2023-01-01T00:00:00.000Z timestamp=2023-01-02T00:00:00.000Z 50
S: ergo BATCH +1 draft/chathistory-targets
S: ergo BATCH -1

Expected behavior

server should never send BATCH to the client because it was never requested

Code

As you can see in irc/handlers.go:657 batch is used without checking client's capabilities.

[slingamn]

Thanks! It looks like for normal chathistory subcommands (LATEST, AFTER, etc.), this is properly gated on the capability:

ergo/irc/responsebuffer.go

Lines 224 to 233 in bf33fba

	func (rb *ResponseBuffer) StartNestedHistoryBatch(params ...string) (batchID string) {
	var batchType string
	if rb.session.capabilities.Has(caps.Batch) {
	batchType = "chathistory"
	}
	if batchType != "" {
	batchID = rb.StartNestedBatch(batchType, params...)
	}
	return
	}

but I forgot to do it for TARGETS.