Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow +v users to talk in +R channels. #1717

Merged
merged 1 commit into from Jun 29, 2021
Merged

Allow +v users to talk in +R channels. #1717

merged 1 commit into from Jun 29, 2021

Conversation

ajaspers
Copy link
Contributor

Fixes #1715.

@slingamn
Copy link
Member

Could you make it so the two cases (RegisteredOnly and RegisteredOnlySpeak) remain separate, and just add clientModes.HighestChannelUserMode() == modes.Mode(0) at the end of the RegisteredOnly clause?

It almost certainly doesn't matter, but I want to avoid taking the client mutex in the case where the mode isn't set.

@ajaspers
Copy link
Contributor Author

Could you make it so the two cases (RegisteredOnly and RegisteredOnlySpeak) remain separate, and just add clientModes.HighestChannelUserMode() == modes.Mode(0) at the end of the RegisteredOnly clause?

It almost certainly doesn't matter, but I want to avoid taking the client mutex in the case where the mode isn't set.

Done.

@slingamn slingamn merged commit 5daabdd into ergochat:master Jun 29, 2021
@ajaspers ajaspers deleted the voice branch June 29, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unregistered users with +v or higher should be exempted from +R
2 participants
@ajaspers @slingamn